Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Use the v2 lookup API for 3PID invites #5861

Closed
jryans opened this issue Aug 15, 2019 · 2 comments
Closed

Use the v2 lookup API for 3PID invites #5861

jryans opened this issue Aug 15, 2019 · 2 comments
Assignees
Labels
z-privacy-sprint (Deprecated Label)

Comments

@jryans
Copy link
Contributor

jryans commented Aug 15, 2019

When processing a 3PID invite, the HS currently looks up the 3PID on the IS using v1/lookup.

MSC2134 has defined a v2/lookup API that supports using hashed addresses. (More discussion is needed to decide whether the HS should use hash alg none and continue to send plain text for this case or instead actually hash the value from HS to IS.)

Since the intention is to remove the v1 IS API down the road, we'll want to do this migration to cover all usages of v1.

@jryans jryans added z-privacy-sprint (Deprecated Label) phase:1 labels Aug 15, 2019
@jryans
Copy link
Contributor Author

jryans commented Aug 19, 2019

We believe this is code path is unused by Riot today, as it does the lookup itself, but it seems still important for other client where we don't know how they handle 3PID invites.

anoadragon453 added a commit that referenced this issue Aug 28, 2019
Fixes #5861

Adds support for the v2 lookup API as defined in [MSC2134](matrix-org/matrix-spec-proposals#2134). Currently this is only used for 3PID invites.

Sytest PR: matrix-org/sytest#679
@anoadragon453 anoadragon453 self-assigned this Sep 5, 2019
@anoadragon453
Copy link
Member

Done in #5897, #5979

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
z-privacy-sprint (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

2 participants