Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v2 lookup support to sytest identity server #679

Merged
merged 5 commits into from
Aug 28, 2019
Merged

Add v2 lookup support to sytest identity server #679

merged 5 commits into from
Aug 28, 2019

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Aug 22, 2019 •
edited
Loading

Adds the /v2/hash_details and /v2/lookup endpoints to the built-in sytest identity server.

Synapse PR: matrix-org/synapse#5897

@anoadragon453 anoadragon453 self-assigned this Aug 22, 2019
@anoadragon453 anoadragon453 marked this pull request as ready for review August 28, 2019 10:47
@anoadragon453 anoadragon453 mentioned this pull request Aug 28, 2019
Merged
@anoadragon453 anoadragon453 requested a review from a team August 28, 2019 10:47
@anoadragon453
Copy link
Member Author

Oops, hold up. Found an edge case.

@anoadragon453 anoadragon453 removed the request for review from a team August 28, 2019 10:53
@anoadragon453
Copy link
Member Author

Ok, all better now.

@anoadragon453 anoadragon453 requested a review from a team August 28, 2019 11:04
erikjohnston
erikjohnston approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this works

@anoadragon453 anoadragon453 merged commit 8e34332 into develop Aug 28, 2019
@anoadragon453 anoadragon453 deleted the anoa/v2_lookup branch August 28, 2019 12:59
anoadragon453 added a commit to matrix-org/synapse that referenced this pull request Aug 28, 2019
@anoadragon453
Use the v2 lookup API for 3PID invites (#5897)
71fc040 
Fixes #5861

Adds support for the v2 lookup API as defined in [MSC2134](matrix-org/matrix-spec-proposals#2134). Currently this is only used for 3PID invites.

Sytest PR: matrix-org/sytest#679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees

@anoadragon453 anoadragon453

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoadragon453 @erikjohnston