Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Test cancellation at every await during request handling #12674

Merged
merged 26 commits into from
Jun 7, 2022
Merged

Test cancellation at every await during request handling #12674

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
ee4b420
Add `_test_cancellation_at_every_await` helper method
May 6, 2022
92045c8
Fix mypy thinking `RoomBase.servlets` is a `List[function]`
May 6, 2022
97b6b1e
Add tests for `/rooms/<room_id>/members` cancellation
May 6, 2022
8d7b495
Add tests for `/rooms/<room_id>/state` cancellation
May 6, 2022
b7aa039
Add dummy newsfile
May 9, 2022
91376e9
Merge remote-tracking branch 'origin/develop' into squah/test_cancell…
May 27, 2022
c980eff
Write a proper newsfile
May 27, 2022
4bf4738
Reword failure message about `await_result=False`
May 31, 2022
85a051e
`request_number` starts at 1
May 31, 2022
1ec2689
Use `reactor.advance()` instead of `reactor.pump()`
May 31, 2022
2cc45c3
Outdent `else` branch
May 31, 2022
9543d43
Un-instance method a bunch of functions
May 31, 2022
74a6bc7
Return a `FakeChannel` from `_test_cancellation_at_every_await` and l…
May 31, 2022
18dc8c0
Turn `create_deferred___next___patch` and its return values into an o…
May 31, 2022
9955d92
Raise `AssertionError`s ourselves
May 31, 2022
32dc933
Un-instance method `_test_cancellation_at_every_await`
May 31, 2022
633c48f
Revert "Fix mypy thinking `RoomBase.servlets` is a `List[function]`"
May 31, 2022
2f4aeee
Rename `test_cancellation_at_every_await` to `make_request_with_cance…
May 31, 2022
fa6245a
Fix out-of-date docstring args
Jun 1, 2022
3a73d6f
Replace `ThreadedMemoryReactorClock` with `MemoryReactorClock`
Jun 1, 2022
39ed2b3
Update docstring about `Deferred.__next__`'s behaviour
Jun 1, 2022
1ff9391
Outdent the if blocks in the `Deferred.__next__` patch
Jun 1, 2022
9ebcf38
Use `channel.await_result()` instead of `reactor.advance()` on final …
Jun 1, 2022
2a5b800
Take the status code from the `Request` instead of the `respond_with_…
Jun 1, 2022
a3e9cce
Reword comments about re-starting of finished logging contexts
Jun 1, 2022
1223c2d
When waiting for a response after a disconnect, try unblocking awaits…
Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/12674.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add tests for cancellation of `GET /rooms/$room_id/members` and `GET /rooms/$room_id/state` requests.
Loading