-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Enable Complement testing in the 'Twisted Trunk' CI runs. #13079
Conversation
4e3a5bc
to
d88efe2
Compare
7362055
to
87040e4
Compare
DEBUG try 1.1.12
87040e4
to
5c37295
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it does what it says on the tin.
I'm started to become a bit concerned about the amount of duplication we have around running complement (we have the complement
and complement-develop
jobs and now this one). I'd be curious to see how much of it we can shove in a common action or script that would prevent us from having to duplicate this code.
path: synapse | ||
|
||
# This step is specific to the 'Twisted trunk' test run: | ||
- name: Patch dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit sad that this step alone takes 5min to run but if we only run it nightly that's probably fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but afraid I can't see any way to do this better (most of the time seemed to be Poetry dependency resolution IIRC, which we already know is slow)
This is no longer true BTW :-) |
Sure but now we have the original |
if you have any decent ideas to improve it, let me know. I'm afraid I can't figure anything that useful out (unless I extract all the shell commands out to some scripts, but that makes it less readable) Note that the other kinds of tests also have this duplication Edit: I think I came up with something passable; see #13157. |
Fixes part of #12934.
To do later: