Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Enable Complement testing in the 'Twisted Trunk' CI runs. #13079

Merged
merged 6 commits into from
Jul 1, 2022

Conversation

reivilibre
Copy link
Contributor

@reivilibre reivilibre commented Jun 16, 2022

Fixes part of #12934.

To do later:

  • remove temporary enablement of the jobs in PRs

@reivilibre reivilibre force-pushed the rei/complement_in_the_trunk branch 7 times, most recently from 4e3a5bc to d88efe2 Compare June 16, 2022 12:00
@reivilibre reivilibre marked this pull request as ready for review June 29, 2022 16:08
@reivilibre reivilibre requested a review from a team as a code owner June 29, 2022 16:08
@babolivier babolivier self-assigned this Jul 1, 2022
Copy link
Contributor

@babolivier babolivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it does what it says on the tin.

I'm started to become a bit concerned about the amount of duplication we have around running complement (we have the complement and complement-develop jobs and now this one). I'd be curious to see how much of it we can shove in a common action or script that would prevent us from having to duplicate this code.

path: synapse

# This step is specific to the 'Twisted trunk' test run:
- name: Patch dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit sad that this step alone takes 5min to run but if we only run it nightly that's probably fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but afraid I can't see any way to do this better (most of the time seemed to be Poetry dependency resolution IIRC, which we already know is slow)

@reivilibre
Copy link
Contributor Author

we have the complement and complement-develop

This is no longer true BTW :-)

@reivilibre reivilibre enabled auto-merge (squash) July 1, 2022 14:22
@babolivier
Copy link
Contributor

This is no longer true BTW :-)

Sure but now we have the original complement job and this one, and the latter is duplicating a fair amount of code from the former.

@reivilibre
Copy link
Contributor Author

reivilibre commented Jul 1, 2022

This is no longer true BTW :-)

Sure but now we have the original complement job and this one, and the latter is duplicating a fair amount of code from the former.

if you have any decent ideas to improve it, let me know. I'm afraid I can't figure anything that useful out (unless I extract all the shell commands out to some scripts, but that makes it less readable)

Note that the other kinds of tests also have this duplication

Edit: I think I came up with something passable; see #13157.

@reivilibre reivilibre merged commit c04e257 into develop Jul 1, 2022
@reivilibre reivilibre deleted the rei/complement_in_the_trunk branch July 1, 2022 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants