This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add a cache for initialSync responses that expires after 5 minutes #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # missed most of the time. So we just lookup the key in all of the | ||
| # dictionaries rather than trying to short circuit the lookup if the | ||
| # key is found. | ||
| result = self.prev_result_cache.get(key) |
There was a problem hiding this comment.
Uh nevermind... Though maybe put that as default anyway to not confuse the next person? ;)
NegativeMjark
added a commit
to matrix-org/sytest
that referenced
this pull request
Dec 23, 2015
Work around the changes in matrix-org/synapse#457
NegativeMjark
added a commit
to matrix-org/sytest
that referenced
this pull request
Dec 23, 2015
Fix tests of /initialSync to work when the response is being cached Work around the changes in matrix-org/synapse#457
|
lgtm |
NegativeMjark
added a commit
that referenced
this pull request
Dec 23, 2015
Add a cache for initialSync responses that expires after 5 minutes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs matrix-org/sytest#124 to land first