Fix tests of /initialSync to work when the response is being cached #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| matrix_initialsync( $user )->then( sub { | ||
| })->then( sub { | ||
| matrix_initialsync( $user ); |
There was a problem hiding this comment.
Rather that this, use the same limit trick as before. At the top of the file put something like
# An incrementing parameter for initialSync to defeat the caching mechanism and ensure fresh results every time
my $initial_sync_limit = 1;
Then change every occurance of matrix_initialsync( $user ) to
matrix_initialsync( $user, limit => $initial_sync_limit++ );
| @@ -32,7 +34,7 @@ | |||
| check => sub { | |||
| my ( $user ) = @_; | |||
|
|
|||
| matrix_initialsync( $user )->then( sub { | |||
| matrix_initialsync( $user, limit => $initial_sync_limit++ )->then( sub { | |||
There was a problem hiding this comment.
could you add a comment to say what the limit is for?
|
Leo's batshit whitespace conventions always catch me out, so I've probably missed something, but looks fine except for some nits |
Work around the changes in matrix-org/synapse#457
NegativeMjark
force-pushed
the
markjh/cached_sync
branch
from
897709a
to
6945bee
Compare
NegativeMjark
added a commit
that referenced
this pull request
Dec 23, 2015
Fix tests of /initialSync to work when the response is being cached Work around the changes in matrix-org/synapse#457
|
Posthoc LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around the changes in matrix-org/synapse#457