This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add experimental 'databases' config #6580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
approved these changes
Jan 2, 2020
synapse/config/database.py
Outdated
|
|
||
| self.databases = [ | ||
| DatabaseConnectionConfig( | ||
| name, db_conf, data_stores=db_conf.get("data_stores") |
There was a problem hiding this comment.
should data_stores be a required option? it feels like defaulting to "all data stores" is maybe unhelpful.
There was a problem hiding this comment.
It's mainly useful so that people with a single database don't have to enumerate all the different types of data stores (on the assumption we'll want to keep splitting them out).
Potentially the correct thing here would be to default to data stores that aren't otherwise provisioned?
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '9f6c1befb': Add experimental 'databases' config (#6580)
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as add a bit of sanity checking that we've specified all the necessary data stores.
This is mainly so that we can added a sytest to make sure that a multi database configuration actually works. (
A sytest PR will be incomingmatrix-org/sytest#775)