Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for synapse multi DB setups. #775

Merged
merged 6 commits into from
Jan 6, 2020

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Dec 20, 2019

This allows specifying a databases.yaml file that contains multiple
databases.

I don't really know if this is the right way of doing it.

Uses matrix-org/synapse#6580

This allows specifying a `databases.yaml` file that contains multiple
databases.
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems generally plausible.

I assume we can't yet delete _get_db_config? We should have a plan for it not to hang around as a massive c&p forever though. What's the plan for it? could you put a comment or something in?

scripts/synapse_sytest.sh Outdated Show resolved Hide resolved
lib/SyTest/Homeserver.pm Show resolved Hide resolved
@erikjohnston
Copy link
Member Author

I assume we can't yet delete _get_db_config? We should have a plan for it not to hang around as a massive c&p forever though. What's the plan for it? could you put a comment or something in?

Its used by dendrite config, which then pulls out the args and constructs a postgres URI string. My thought was that we probably don't want to try and use the same config format for dendrite and synapse TBH.

@erikjohnston erikjohnston merged commit fda574f into develop Jan 6, 2020
anoadragon453 added a commit that referenced this pull request Mar 20, 2020
…ase-v1.8.x

* origin/release-v1.8.0: (27 commits)
  Test for outliers whose auth events are in a different room
  Test for receiving events with auth events in the wrong room
  enable frozen dicts in synapse (#778)
  Fix c&p error in #779
  Add support for synapse multi DB setups. (#775)
  Add console feedbak for the TAP output mode (#779)
  workaround for matrix-org/synapse#6536 (#772)
  Test for backfilled events whose prev_events cross room boundaries (#769)
  Add dendrite's logs to buildkite's artifacts (#773)
  Make the replication torture level adjustable (#771)
  Add test for removing redactions from search results (#747)
  Sanity-checking of some params (#765)
  Fix some 'undefined value' warnings (#768)
  Remove redundant fallback in on_request_federation_v1_event (#766)
  Deflake an AS test (#764)
  Add tests for outbound v2 invite API
  Fix diagnostics from logout test (#763)
  Add comment to explain what the v1 outbound test relies on
  Re-fix test names
  Fix test names
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants