This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Rewrite _EventInternalMetadata to back it with a dict #6872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/dictproperty
branch
from
61d7085 to
9594c24
Compare
richvdh
force-pushed
the
rav/dictproperty
branch
2 times, most recently
from
b8146d6 to
630e618
Compare
this amounts to the same thing, but replaces `_event_dict` with `_dict`, and removes some of the function layers generated by `property`.
Mostly, this gives mypy an easier time.
richvdh
force-pushed
the
rav/dictproperty
branch
from
630e618 to
5a78f47
Compare
erikjohnston
approved these changes
Feb 18, 2020
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '3f1cd1479': changelog Rewrite _EventInternalMetadata to back it with a _dict Replace _event_dict_property with DictProperty
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... but first, replace _event_dict_property with DictProperty. I think that this removes a layer of function dispatch for each lookup.