Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add a worker store for search insertion. #7516

Merged
merged 2 commits into from
May 15, 2020
Merged

Conversation

erikjohnston
Copy link
Member

This is required as both event persistence and the background update needs access to this function. It should be perfectly safe for two workers to write to that table at the same time.

This is required as both event persistence and the background update
needs access to this function.
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is "safe" to run on multiple workers at once since it is insert only and the event IDs should be unique?

@erikjohnston
Copy link
Member Author

Yeah, and we don't have caches and things to worry about.

@erikjohnston erikjohnston merged commit 03aff4c into develop May 15, 2020
@erikjohnston erikjohnston deleted the erikj/search_store branch May 15, 2020 16:22
phil-flex pushed a commit to phil-flex/synapse that referenced this pull request Jun 16, 2020
This is required as both event persistence and the background update needs access to this function. It should be perfectly safe for two workers to write to that table at the same time.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants