Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add option to move event persistence off master #7517

Merged
merged 21 commits into from
May 22, 2020
Merged

Add option to move event persistence off master #7517

merged 21 commits into from
May 22, 2020

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented May 15, 2020 •
edited
Loading

This adds config of the form:

writers:
    events: some_worker_name

(Better names for config option would be appreciated).

Requires #7515 and #7516

@erikjohnston erikjohnston requested a review from a team May 15, 2020 16:50
@erikjohnston erikjohnston mentioned this pull request May 15, 2020
Merged
anoadragon453
anoadragon453 suggested changes May 18, 2020
View reviewed changes
synapse/config/workers.py Outdated Show resolved Hide resolved
synapse/replication/tcp/handler.py Outdated Show resolved Hide resolved
synapse/handlers/message.py Outdated Show resolved Hide resolved
synapse/storage/data_stores/__init__.py Outdated Show resolved Hide resolved
synapse/storage/data_stores/__init__.py Show resolved Hide resolved
anoadragon453
anoadragon453 approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, take or leave the nit :)

synapse/handlers/message.py Outdated Show resolved Hide resolved
@erikjohnston erikjohnston force-pushed the erikj/move_events branch 4 times, most recently from 0e58aaf to f1589f0 Compare May 21, 2020 09:25
@erikjohnston
Copy link
Member Author

The commits are mostly me sorting out a bad merge. The test failure is a flakey sytest that I'm dealing with separately.

@erikjohnston erikjohnston merged commit e5c67d0 into develop May 22, 2020
@erikjohnston erikjohnston deleted the erikj/move_events branch May 22, 2020 15:11
@clokep clokep mentioned this pull request Jun 15, 2020
Open
phil-flex pushed a commit to phil-flex/synapse that referenced this pull request Jun 16, 2020
@erikjohnston @phil-flex
Add option to move event persistence off master (matrix-org#7517)
90dfae3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikjohnston @anoadragon453