Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker builds again #1339

Merged
merged 5 commits into from
Mar 17, 2023
Merged

Fix docker builds again #1339

merged 5 commits into from
Mar 17, 2023

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented Mar 9, 2023 •
edited
Loading

Commitwise reviewable.

Previous attempt in this area was #1334

@DMRobertson DMRobertson force-pushed the dmr/fix-docker-build branch from 7fa2590 to 313bb50 Compare March 9, 2023 13:03
David Robertson added 5 commits March 9, 2023 13:44
Fix removed build arg
8ae5962 
Screwup in 1334
Actually, remove bookworm
64c6405 
Testing is currently the same thing as bookworm, and we never use the
bookworm tag in Synapse's CI.
Make --break-system-packages optional
bce3b8e
Opt into nobbling system installation on bookworm
87c10e3
Only build once per branch/PR
0b830b2
@DMRobertson DMRobertson force-pushed the dmr/fix-docker-build branch from dfbfcb9 to 0b830b2 Compare March 9, 2023 13:48
@DMRobertson DMRobertson changed the title WIP Dmr/fix docker build Fix docker builds again Mar 9, 2023
@DMRobertson DMRobertson marked this pull request as ready for review March 9, 2023 13:49
@DMRobertson DMRobertson requested a review from a team as a code owner March 9, 2023 13:49
clokep
clokep approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this looks OK. 👍

@clokep clokep merged commit cdac5a1 into develop Mar 17, 2023
@clokep clokep deleted the dmr/fix-docker-build branch March 17, 2023 13:13
@DMRobertson DMRobertson mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clokep clokep clokep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DMRobertson @clokep