Drop old oldstable buster and sub new oldstable bullseye #1358
Conversation
| # For now, we need to tell Debian we don't care that we're editing the system python | ||
| # installation. | ||
| # Some context in https://github.com/pypa/pip/issues/11381#issuecomment-1399263627 | ||
| RUN ${PYTHON_VERSION} -m pip install -q --upgrade pip ${SYSTEM_PIP_INSTALL_SUFFIX} |
There was a problem hiding this comment.
My thinking on dropping this is my reading of the issue mentioned indicates that the version of pip shipped in bullseye (20.3.4-4) should be sufficient as it is greater than 19?
There was a problem hiding this comment.
The change seems sane to me (even though the sytest docker machinery does not).
I don't follow what is meant by
For now, we need to tell Debian we don't care that we're editing the system python installation. Some context in pypa/pip#11381 (comment)
which is amusing because I wrote the comment. #1334 and #1339 shed some light.
I think it's referring to SYSTEM_PIP_INSTALL_SUFFIX, and I think we probably need to leave this in place for now (unless every distribution is happy with the --break-system-packages option).
There was a problem hiding this comment.
Just to be clear, when you refer to "I think we probably need to leave this in place for now", do you mean the SYSTEM_PIP_INSTALL_SUFFIX on line 31/27, or are you referring to the removal on line 30? (My assumption is that you mean the former but just wanted to be sure)
There was a problem hiding this comment.
do you mean the SYSTEM_PIP_INSTALL_SUFFIX on line 31/27, or are you referring to the removal on line 30?
Sorry: the former, keeping SYSTEM_PIP_INSTALL_SUFFIX as the diff is currently.
|
I did a manual run of the build pipeline (on this new branch) to verify that everything builds properly: https://github.com/matrix-org/sytest/actions/runs/5489675592/jobs/10005024592 |
| tags: "matrixdotorg/sytest-synapse:buster" | ||
| build_args: "SYTEST_IMAGE_TAG=buster" | ||
| tags: "matrixdotorg/sytest-synapse:bullseye" | ||
| build_args: "SYTEST_IMAGE_TAG=bullseye" |
There was a problem hiding this comment.
I'm somewhat surprised that we don't need SYSTEM_PIP_INSTALL_SUFFIX=--break-system-packages here, but if it works then LGTM.
There was a problem hiding this comment.
(it doesn't help that I don't grok Debian's version naming scheme.)
There was a problem hiding this comment.
My assumption is that it works? The dockerfiles seemed to build but I could be missing something here?
There was a problem hiding this comment.
IIRC I added the SYSTEM_PIP_INSTALL_SUFFIX stuff to get sytest working under debian testing. I had assumed bullseye was brand-new latest release and so would need this too, but that's not the case: bullseye is nearly two years old.
So yeah, given that the docker images build this is fine. Sorry for the noise.
There was a problem hiding this comment.
Not at all I appreciate the insight!
| # For now, we need to tell Debian we don't care that we're editing the system python | ||
| # installation. | ||
| # Some context in https://github.com/pypa/pip/issues/11381#issuecomment-1399263627 | ||
| RUN ${PYTHON_VERSION} -m pip install -q --upgrade pip ${SYSTEM_PIP_INSTALL_SUFFIX} |
There was a problem hiding this comment.
The change seems sane to me (even though the sytest docker machinery does not).
I don't follow what is meant by
For now, we need to tell Debian we don't care that we're editing the system python installation. Some context in pypa/pip#11381 (comment)
which is amusing because I wrote the comment. #1334 and #1339 shed some light.
I think it's referring to SYSTEM_PIP_INSTALL_SUFFIX, and I think we probably need to leave this in place for now (unless every distribution is happy with the --break-system-packages option).
|
Merged #1358 into develop, thanks for the review! |
As part of dropping support for python 3.7, drop debian buster (python version 3.7) and sub in debian bullseye (python 3.9).
Corresponding Synapse PR's: matrix-org/synapse#15892, matrix-org/synapse#15893