Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: App launcher icon colors don't match the theme #1095

Closed
ogi-m opened this issue Aug 25, 2021 · 2 comments · Fixed by #1138
Closed

Bug: App launcher icon colors don't match the theme #1095

ogi-m opened this issue Aug 25, 2021 · 2 comments · Fixed by #1138
Assignees
@asaadmahmood
Labels
Bug Something isn't working QA Verified Bug fix tested and verified by QA
Milestone
v0.9

Comments

@ogi-m
Copy link
Contributor

ogi-m commented Aug 25, 2021

Summary:
The icons in the app launcher for Channels, Playbooks and Boards seem to follow the text color instead of the icon color set in Channels.

Steps to reproduce the behavior:

  1. Set a theme in Channels
  2. Open app launcher and observe the icon color
  3. Open Boards
  4. Open app launcher and observe the icon color

Expected behavior:
Icon color should match the ones in Channels

Screenshots:
channels_icons focalboard_icons

Platform:

  • Browser and version: [e.g. Chrome 88, Safari 12]
  • OS and version: [e.g. Windows, macOS 10.15.7, iOS 13.1]

Additional context:
Probably related to #1012
@ogi-m ogi-m added the Bug Something isn't working label Aug 25, 2021
@ogi-m ogi-m mentioned this issue Aug 25, 2021
Closed
@chenilim chenilim added this to the v0.9 milestone Aug 31, 2021
@asaadmahmood asaadmahmood mentioned this issue Aug 31, 2021
Merged
@ogi-m
Copy link
Contributor Author

ogi-m commented Sep 7, 2021 •
edited
Loading

@asaadmahmood The icons for the products now match, but the ones below do not:

channels_icons boards_icons

@ogi-m ogi-m reopened this Sep 7, 2021
@asaadmahmood asaadmahmood mentioned this issue Sep 7, 2021
Merged
sbishel added a commit to asaadmahmood/focalboard that referenced this issue Sep 9, 2021
@sbishel
Merge branch 'main' into mattermost-communitygh-1095
cc4ff76
asaadmahmood added a commit to asaadmahmood/focalboard that referenced this issue Sep 10, 2021
@asaadmahmood
Merge branch 'main' into mattermost-communitygh-1095
adb651c
@ogi-m
Copy link
Contributor Author

ogi-m commented Sep 15, 2021

Verified on RC11

@ogi-m ogi-m added the QA Verified Bug fix tested and verified by QA label Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asaadmahmood asaadmahmood

Labels
Bug Something isn't working QA Verified Bug fix tested and verified by QA
Projects
None yet
Milestone
v0.9
Development

Successfully merging a pull request may close this issue.

1112 - Updating button active state in viewHeader asaadmahmood/focalboard
3 participants
@asaadmahmood @ogi-m @chenilim