GH-994 - Updating color for global header menu #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaadmahmood
added
2: Dev Review
wiggin77
approved these changes
Aug 16, 2021
There was a problem hiding this comment.
LGTM 👍 @asaadmahmood , I think your editor has different formatting settings from the other devs. We should all get in sync otherwise we'll keep clobbering each other's formatting.
hahmadia
approved these changes
Aug 17, 2021
jespino
requested changes
Aug 17, 2021
| } | ||
|
|
||
| .feature-global-header { |
There was a problem hiding this comment.
This is going to affect the .feature-global-header of outside focalboard too. if you combine this with the previous one you can make it better. Something like:
.focalboard-body .feature-global-header {
>header {
z-index: 1000;
}
.Menu {
...There was a problem hiding this comment.
@jespino Done.
jespino
approved these changes
Aug 19, 2021
jespino
added
CherryPick/Approved
|
This can be tested after merge. |
jespino
added
3: Reviews Complete
|
Cherry pick is scheduled. |
|
Error trying doing the automated Cherry picking. Please do this manually |
jespino
added a commit
that referenced
this pull request
Aug 19, 2021
* Updating color for global header menu * Updating css Co-authored-by: Jesús Espino <jespinog@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GH-994 - Updating color for global header menu
Ticket Link
#994
Screenshot