Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTUE - Dashboard #1177

Merged
merged 21 commits into from
Sep 14, 2021
Merged

FTUE - Dashboard #1177

merged 21 commits into from
Sep 14, 2021

Conversation

harshilsharma63
Copy link
Member

@harshilsharma63 harshilsharma63 requested a review from a team as a code owner September 10, 2021 10:38
@harshilsharma63 harshilsharma63 requested review from wiggin77, hahmadia and sbishel and removed request for a team, wiggin77 and hahmadia September 10, 2021 10:38
@justinegeffen justinegeffen added 2: Dev Review Requires review by a core committer Docs/Needed labels Sep 10, 2021
justinegeffen
justinegeffen reviewed Sep 10, 2021
View reviewed changes
Copy link
Contributor

@justinegeffen justinegeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor edits and a suggested rewrite for the results content. Happy to discuss that further!

webapp/i18n/en.json Outdated Show resolved Hide resolved
webapp/i18n/en.json Outdated Show resolved Hide resolved
webapp/i18n/en.json Outdated Show resolved Hide resolved
webapp/i18n/en.json Outdated Show resolved Hide resolved
webapp/src/components/workspaceSwitcher/__snapshots__/workspaceSwitcher.test.tsx.snap Show resolved Hide resolved
webapp/src/components/workspaceSwitcher/__snapshots__/workspaceSwitcher.test.tsx.snap Show resolved Hide resolved
webapp/src/components/workspaceSwitcher/__snapshots__/workspaceOptions.test.tsx.snap Show resolved Hide resolved
webapp/src/components/workspaceSwitcher/__snapshots__/workspaceOptions.test.tsx.snap Show resolved Hide resolved
harshilsharma63 and others added 6 commits September 13, 2021 10:42
@harshilsharma63 @justinegeffen
Update webapp/i18n/en.json
93f0afa 
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
@harshilsharma63 @justinegeffen
Updated docs
d2b7ff6 
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
@harshilsharma63 @justinegeffen
Update webapp/i18n/en.json
e7bce32 
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
@harshilsharma63
Merge branch 'main' into ftue-dashboard
ba94a66
@harshilsharma63
Disabled image
5347bac
@harshilsharma63
FIxed tests
bf7fae8
sbishel
sbishel requested changes Sep 13, 2021
View reviewed changes
Copy link
Collaborator

@sbishel sbishel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into a few issues while testing -

It matches figma, so more a question for @asaadmahmood, the button to hide the sidebar is no longer available.
Screen Shot 2021-09-13 at 10 41 39 AM

When in Dashboard, "Add Board" should not be available. (It actually adds to last viewed board, if you add a board)
Screen Shot 2021-09-13 at 10 40 21 AM

Direct channels Title does not display in either Dropdown or Dashboard. Group messages appear fine.
Screen Shot 2021-09-13 at 8 50 29 AM

Screen Shot 2021-09-13 at 8 49 14 AM

Screen Shot 2021-09-13 at 8 49 30 AM

webapp/src/components/sidebar/sidebar.tsx Outdated Show resolved Hide resolved
webapp/src/components/sidebar/sidebar.tsx Show resolved Hide resolved
@harshilsharma63
Copy link
Member Author

@sbishel

When in Dashboard, "Add Board" should not be available. (It actually adds to last viewed board, if you add a board)

Fixed. It's now hidden in the dashboard view.

Direct channels Title does not display in either Dropdown or Dashboard. Group messages appear fine

It was already fixed in a separate PR (#1179).
Screenshot 2021-09-14 at 12 30 48 PM
Screenshot 2021-09-14 at 12 31 07 PM

@harshilsharma63 harshilsharma63 mentioned this pull request Sep 14, 2021
Merged
@justinegeffen
Copy link
Contributor

Added the docs needed label as the docs will need to be updated, but it's not a blocker to merge.

@justinegeffen justinegeffen added the Documentation Improvements or additions to documentation label Sep 14, 2021
sbishel
sbishel approved these changes Sep 14, 2021
View reviewed changes
Copy link
Collaborator

@sbishel sbishel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging. I did create a bug related to this PR or #1179

#1205

@sbishel sbishel added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 14, 2021
@sbishel sbishel merged commit d0ba389 into main Sep 14, 2021
@sbishel sbishel deleted the ftue-dashboard branch September 14, 2021 16:42
@sbishel sbishel added this to the v0.9 milestone Sep 14, 2021
@sbishel sbishel added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Sep 14, 2021
sbishel pushed a commit to sbishel/focalboard that referenced this pull request Sep 14, 2021
@harshilsharma63 @sbishel
FTUE - Dashboard (mattermost-community#1177)
b925990 
* Dashboard UI complete

* Updating UI changes

* Finishing touches

* Made navigation better

* Updated dashboard navigation

* Fixed spacing issue

* Fixed spacing issue

* Updating UI

* Fixed a CSS linter issue

* Update webapp/i18n/en.json

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Updated docs

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update webapp/i18n/en.json

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Disabled image

* FIxed tests

* Review fixes

Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
(cherry picked from commit d0ba389)
harshilsharma63 added a commit that referenced this pull request Sep 15, 2021
@harshilsharma63 @asaadmahmood
@justinegeffen @sbishel
FTUE - Dashboard (#1177)
d1ec870 
* Dashboard UI complete

* Updating UI changes

* Finishing touches

* Made navigation better

* Updated dashboard navigation

* Fixed spacing issue

* Fixed spacing issue

* Updating UI

* Fixed a CSS linter issue

* Update webapp/i18n/en.json

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Updated docs

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update webapp/i18n/en.json

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Disabled image

* FIxed tests

* Review fixes

Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
@harshilsharma63 harshilsharma63 mentioned this pull request Sep 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbishel sbishel sbishel approved these changes

@justinegeffen justinegeffen justinegeffen approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request CherryPick/Approved Meant for the quality or patch release tracked in the milestone Docs/Needed Documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@harshilsharma63 @justinegeffen @sbishel @asaadmahmood