Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displayed channels names for DMs in user workspace list #1179

Merged
merged 3 commits into from
Sep 13, 2021

Conversation

harshilsharma63
Copy link
Member

Summary

Displayed channels names for DMs in user workspace list

Ticket Link

NA

Fixes the issue where getUserWorkspaces() API didn't return workspace names corresponding to DM channels.

Before-
before

After-
after

@harshilsharma63 harshilsharma63 requested a review from a team as a code owner September 10, 2021 12:34
@harshilsharma63 harshilsharma63 requested review from hahmadia, a team and wiggin77 and removed request for a team, hahmadia and wiggin77 September 10, 2021 12:34
@harshilsharma63 harshilsharma63 added the 2: Dev Review Requires review by a core committer label Sep 10, 2021
Copy link
Contributor

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshilsharma63 harshilsharma63 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 13, 2021
@harshilsharma63 harshilsharma63 merged commit 20aafbc into main Sep 13, 2021
@harshilsharma63 harshilsharma63 deleted the workspace-dm-support branch September 13, 2021 12:12
@chenilim chenilim added this to the v0.9 milestone Sep 14, 2021
@chenilim chenilim added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Sep 14, 2021
@harshilsharma63 harshilsharma63 linked an issue Sep 16, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request CherryPick/Approved Meant for the quality or patch release tracked in the milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Dashboard does not show names of DM channels
3 participants