Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide UsePreregisteredApplication on on-prem instances #647

Closed
hanzei opened this issue Feb 27, 2023 · 3 comments · Fixed by #774
Closed

Hide UsePreregisteredApplication on on-prem instances #647

hanzei opened this issue Feb 27, 2023 · 3 comments · Fixed by #774
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted

Comments

@hanzei
Copy link
Contributor

hanzei commented Feb 27, 2023

The UsePreregisteredApplication setting should only be used on Cloud instances. To avoid confusion, the settings should not be visible on on-prem instances. This can be done using the hosting field.
@hanzei hanzei added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Good First Issue Suitable for first-time contributors Difficulty/1:Easy Easy ticket labels Feb 27, 2023
@hanzei
Copy link
Contributor Author

hanzei commented Apr 30, 2024

@mattermost/contractor-brightscout Can you please take care of this? I would love to avoid the confusion that UsePreregisteredApplication has been causing for on-prem customers.

@Kshitij-Katiyar
Copy link
Contributor

sure @hanzei working on this.

@hanzei
Copy link
Contributor Author

hanzei commented May 1, 2024

Thanks @Kshitij-Katiyar 👍

Kshitij-Katiyar added a commit that referenced this issue May 2, 2024
@Kshitij-Katiyar
[GH-647]: Hide UsePreregisteredApplication on on-prem instances
d16dcce
@Kshitij-Katiyar Kshitij-Katiyar mentioned this issue May 2, 2024
Merged
@hanzei hanzei linked a pull request May 2, 2024 that will close this issue
[GH-647]: Hide UsePreregisteredApplication on on-prem instances #774
Merged
mickmister pushed a commit that referenced this issue May 4, 2024
@Kshitij-Katiyar
[GH-647]: Hide UsePreregisteredApplication on on-prem instances (#774)
da4c4df 
* [GH-647]: Hide UsePreregisteredApplication on on-prem instances

* [MM-647]: Fixed review comments
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted
Projects
Brightscout Plugin Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GH-647]: Hide UsePreregisteredApplication on on-prem instances mattermost/mattermost-plugin-github
2 participants
@hanzei @Kshitij-Katiyar