Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-647]: Hide UsePreregisteredApplication on on-prem instances #774

Merged
merged 2 commits into from
May 4, 2024

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented May 2, 2024

Summary

Using the hoisting property the UsePreregisteredApplication will only be on cloud servers.

Ticket Link

#647

Testing Steps

The UsePreregisteredApplication will be hidden in on-prem servers and can only be seen in cloud instances.

Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update min_server_version to ensure newer server pick up the setting correctly?

plugin.json Outdated Show resolved Hide resolved
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label May 2, 2024
@hanzei hanzei linked an issue May 2, 2024 that may be closed by this pull request
@Kshitij-Katiyar
Copy link
Contributor Author

Should we update min_server_version to ensure newer server pick up the setting correctly?

I have tested this on mattermost cloud server v9.4.0 and it was working fine for that. @hanzei

@mickmister mickmister added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels May 4, 2024
@mickmister mickmister merged commit da4c4df into master May 4, 2024
9 checks passed
@mickmister mickmister deleted the MM-647 branch May 4, 2024 12:22
@hanzei hanzei added this to the v2.3.0 milestone May 4, 2024
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR above has been tested for the config UsePreregisteredApplication for both cloud and on-prem instances. The config is not visible in the plugin configs for on-prem instances of MM. This PR is working fine, approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide UsePreregisteredApplication on on-prem instances
4 participants