Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the new Draft PR behavior configurable #802

Open
ThiefMaster opened this issue Jul 12, 2024 · 0 comments · May be fixed by #804
Open

Make the new Draft PR behavior configurable #802

ThiefMaster opened this issue Jul 12, 2024 · 0 comments · May be fixed by #804
Milestone

Comments

@ThiefMaster
Copy link

If you look at #682 and the underlying issue #680 it's clear that this is highly organization-specific:

Hello, within our organization, we commonly utilize draft pull requests for experimental ideas and prototyping, and convert these drafts pull requests once they are ready for review.

For example, in my case we open Draft PRs simply because e.g. tests have not been fully updated yet or there are still some discussion points.

And there I'd much rather have it show the full message when the PR is opened, and nothing at all when it's changed from/to draft (like it was before #682).

In particular, it's spammy right now when someone opens the PR, then converts it to draft (because they forgot), and then back to a regular one shortly after (that results in a total of two "full" messages and one small).

I think this change would be much more bearable if the plugin kept track of whether a PR was in "ready" state before so the bull message is only sent once. But even then I'd rather have a setting to disable the whole functionality, because depending on the project, Draft PR just means that there's still some stuff left for discussion, but that people still want to be properly informed about the PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Submitted / In Review
2 participants