Delaying Draft Pull Request Notifications until Marked as 'Ready for Review'

[abdulsmapara]

Summary

Delaying Draft Pull Request Notifications until Marked as 'Ready for Review'

Requirement addressed:

• When a draft PR is submitted, an on-line notification gets posted.
• When a draft PR is marked as ready-for-review, a "standard" PR notification with the full body gets posted.

Description

When draft PR created, following message is posted, without PR description/body =>

When PR marked ready for review, following message is posted, which includes PR description/body =>

When PR directly created with ready for review, following message is posted, which includes PR description/body =>

Ticket Link

#680

[mattermost-build]

Hello @abdulsmapara,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[hanzei]

Thanks for the contribution 🎉

[hanzei]

Nice work 👍

[mattermost-build]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

[abdulsmapara]

@DHaussermann, requesting you to please review the PR.
cc: @hanzei

[abdulsmapara]

@DHaussermann, any updates on the PR review ?
cc: @hanzei, @crspeller

[DHaussermann]

Sorry @abdulsmapara for the delay. I will follow-up to find a testing resource for this PR.

[abdulsmapara]

no problem @DHaussermann
Thanks for the update.

[abdulsmapara]

Any update @DHaussermann ?

cc: @hanzei ,@crspeller

[crspeller]

@lindalumitchell Do you have some time to test this PR?

[lindalumitchell]

@crspeller yes, I should be able to; I know Dylan is out next week as well. I'm unsure how to build a test version of the plugin though; can you help?

[hanzei]

/update-branch

[hanzei]

@lindalumitchell You can download the bundle bundle at https://github.com/mattermost/mattermost-plugin-github/actions/runs/5855120323?pr=682.

[lindalumitchell]

Apologies for the further delay on this review; I hadn't tested this area before. But I got it all set up and tested and it looks great! Thanks very much for the contribution!

Verified as described that the simple notification posts on draft PR creation, and full notification posts when marked Ready for Review. Also smoke tested around other actions and notifications with all behaving as expected and no issues found. 👍

[hanzei]

Thanks @abdulsmapara 🚀

[ThiefMaster]

Could this please be made configurable?

I'd much rather have it show the full message when the PR is opened, and nothing at all when it's changed from/to draft (like it was before this PR).

In particular, it's spammy right now when someone opens the PR, then converts it to draft (because they forgot), and then back to a regular one shortly after (that results in a total of two "full" messages and one small).

I think this change would be more bearable if the plugin kept track of whether a PR was in "ready" state before so the bull message is only sent once. But even then I'd rather have a setting to disable the whole functionality, because depending on the project, Draft PR just means that there's still some stuff left for discussion, but that people still want to be properly informed about the PR...