Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement Proposal] Delaying Draft Pull Request Notifications until Marked as 'Ready for Review' #680

Closed
weiiwang01 opened this issue Jun 2, 2023 · 4 comments
Assignees
Labels
Help Wanted Community help wanted Type/Enhancement New feature or improvement of existing feature

Comments

@weiiwang01
Copy link

Hello, within our organization, we commonly utilize draft pull requests for experimental ideas and prototyping, and convert these drafts pull requests once they are ready for review.

At present, the GitHub plugin can trigger a notification whenever a new pull request is created, regardless of it's draft or not. However, it does not send out a notification when that draft pull request is marked as 'ready for review'.

This leads to these pull requests sometimes being overlooked, particularly where there is a long delay between the time of creation and the point at which they are marked ready for review.

As an user, I would appreciate the incorporation of an option that change this behavior so that it could suppress notifications for draft pull requests initially, and instead, issue a notification only when the pull request is converted to 'ready for review'.

@hanzei hanzei added Type/Enhancement New feature or improvement of existing feature Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers and removed Type/Enhancement New feature or improvement of existing feature labels Jun 2, 2023
@abdulsmapara
Copy link
Contributor

Can I take this issue ?

@hanzei
Copy link
Contributor

hanzei commented Jun 5, 2023

@abdulsmapara Sure 👍

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Jun 5, 2023
@hanzei
Copy link
Contributor

hanzei commented Jun 5, 2023

Thanks for the detailed proposal, @weiiwang01 . A channel message when a PR is ready for review sounds good to me. I'm not too keen on adding another setting. What do you think about the following change?

  • When a draft PR is submitted, an on-line notification gets posted.
  • When a draft PR is marked as ready-for-review, a "standard" PR notification with the full body gets posted.

@weiiwang01
Copy link
Author

Thanks for the detailed proposal, @weiiwang01 . A channel message when a PR is ready for review sounds good to me. I'm not too keen on adding another setting. What do you think about the following change?

  • When a draft PR is submitted, an on-line notification gets posted.
  • When a draft PR is marked as ready-for-review, a "standard" PR notification with the full body gets posted.

Yes, that's perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Community help wanted Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Development

No branches or pull requests

3 participants