-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-51245] Handle relative paths in permalinks #656
Conversation
@m1lt0n I have regression tested the feature that control if code previews should show and if they should also be allowed to show from private repos. For the scope on change on this it's a bit unclear to me please reach out if there is further functional testing applicable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Approved unless Dev has further concerns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* disable cgo * bump version 2.1.5 * Bump version to 2.1.5 * [MM-51245] Handle relative paths in permalinks (#656) * [MM-51269] Log errors from telemetry events (#653) * keep telemetry init together and do the enable/disable thing (#659) It places telemetry client and tracker initialization together at onActivate and uses the new enable/disable commands at onConfigurationChange. Also, pass a logger to the telemetry tracker when ServiceSettings.EnableDeveloper is true (through NewTelemetryTracker), which will end up logging the telemetry activity (no matter if the tracking config or client is disabled). This is still 2/5 until backwards-compatibility details are discussed. Added event account_connected when we have an oauth successful connection (through setup or plain connect). * run ci on release branches * remove check for release branch * add nvmrc * add cd workflow --------- Co-authored-by: Pantelis Vratsalis <pvratsalis@gmail.com> Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com> Co-authored-by: José Peso <trilopin@users.noreply.github.com>
Summary
Handle relative paths in permalinks
Ticket Link
https://mattermost.atlassian.net/browse/MM-51245