-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.1.5 #660
Release 2.1.5 #660
Conversation
It places telemetry client and tracker initialization together at onActivate and uses the new enable/disable commands at onConfigurationChange. Also, pass a logger to the telemetry tracker when ServiceSettings.EnableDeveloper is true (through NewTelemetryTracker), which will end up logging the telemetry activity (no matter if the tracking config or client is disabled). This is still 2/5 until backwards-compatibility details are discussed. Added event account_connected when we have an oauth successful connection (through setup or plain connect).
I did some release testing on this today. I see a strange behavior I was not able to isolate where code previews worked normally on some servers but not others. I don't have any info to suggest this is a change between versions but want to take another look. note There is s a complication here where it seems I'm not able to upload any plugins to cloud servers right now. This is making it harder to isolate the issue. I will complete this shortly. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-2.1.5 #660 +/- ##
=================================================
- Coverage 15.51% 15.39% -0.13%
=================================================
Files 15 15
Lines 4151 5191 +1040
=================================================
+ Hits 644 799 +155
- Misses 3465 4350 +885
Partials 42 42
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
- No functional impacts to how code previews is working
- No further testing needed for telemetry
- Smoke tested
- Connect / Disconnect
- Counts are working
- Create and attach functionality are working
- I do see the rate limiting issue but it's not a regression (API rate limit exceeded for user ID #613)
- Version number correct at 2.1.5
LGTM!
Summary
Ticket Link