Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.1.5 #660

Merged
merged 11 commits into from
Mar 27, 2023
Merged

Release 2.1.5 #660

merged 11 commits into from
Mar 27, 2023

Conversation

mickmister
Copy link
Member

@mickmister mickmister commented Mar 20, 2023 •
edited by trilopin

@mickmister mickmister requested a review from hanzei as a code owner March 20, 2023 18:19
@mickmister mickmister changed the base branch from master to release-2.1.5 March 20, 2023 18:19
@mickmister mickmister mentioned this pull request Mar 20, 2023
Merged
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) labels Mar 21, 2023
@hanzei hanzei modified the milestones: v2.2.0, v2.1.5 Mar 21, 2023
m1lt0n and others added 3 commits March 23, 2023 19:57
@m1lt0n @trilopin
[MM-51245] Handle relative paths in permalinks (#656)
00b180e
@hanzei @trilopin
[MM-51269] Log errors from telemetry events (#653)
a9902b2
@trilopin
keep telemetry init together and do the enable/disable thing (#659)
d6446f0 
It places telemetry client and tracker initialization together at onActivate and uses the new enable/disable commands at onConfigurationChange.

Also, pass a logger to the telemetry tracker when ServiceSettings.EnableDeveloper is true (through NewTelemetryTracker), which will end up logging the telemetry activity (no matter if the tracking config or client is disabled). This is still 2/5 until backwards-compatibility details are discussed.

Added event account_connected when we have an oauth successful connection (through setup or plain connect).
@DHaussermann
Copy link

DHaussermann commented Mar 23, 2023 •
edited

I did some release testing on this today.

I see a strange behavior I was not able to isolate where code previews worked normally on some servers but not others. I don't have any info to suggest this is a change between versions but want to take another look.

note There is s a complication here where it seems I'm not able to upload any plugins to cloud servers right now. This is making it harder to isolate the issue.

I will complete this shortly.

@mickmister mickmister added 3: QA Review Requires review by a QA tester and removed 4: Reviews Complete All reviewers have approved the pull request Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) labels Mar 24, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 2.08% and project coverage change: -0.13 ⚠️

Comparison is base (1be093c) 15.51% compared to head (d11111c) 15.39%.

❗ Current head d11111c differs from pull request most recent head 450ac47. Consider uploading reports for the commit 450ac47 to get more accurate results

Additional details and impacted files 
@@                Coverage Diff                @@
##           release-2.1.5     #660      +/-   ##
=================================================
- Coverage          15.51%   15.39%   -0.13%     
=================================================
  Files                 15       15              
  Lines               4151     5191    +1040     
=================================================
+ Hits                 644      799     +155     
- Misses              3465     4350     +885     
  Partials              42       42
Impacted Files Coverage Δ
server/plugin/api.go 7.76% <0.00%> (-0.50%) ⬇️
server/plugin/configuration.go 34.75% <0.00%> (-2.64%) ⬇️
server/plugin/flows.go 0.00% <0.00%> (ø)
server/plugin/plugin.go 3.70% <0.00%> (-0.02%) ⬇️
server/plugin/telemetry.go 0.00% <0.00%> (ø)
server/plugin/permalinks.go 73.19% <100.00%> (+2.82%) ⬆️

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DHaussermann DHaussermann self-requested a review March 24, 2023 18:20
DHaussermann
DHaussermann approved these changes Mar 25, 2023
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • No functional impacts to how code previews is working
  • No further testing needed for telemetry
  • Smoke tested
    • Connect / Disconnect
    • Counts are working
    • Create and attach functionality are working
  • I do see the rate limiting issue but it's not a regression (API rate limit exceeded for user ID #613)
  • Version number correct at 2.1.5

LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Mar 25, 2023
@mickmister mickmister merged commit 7f572a7 into release-2.1.5 Mar 27, 2023
@mickmister mickmister deleted the release-2.1.5-bump branch March 27, 2023 18:46
@mickmister mickmister mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

@DHaussermann DHaussermann DHaussermann approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
Integration Releases
Archived in project
Milestone
v2.1.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mickmister @DHaussermann @codecov-commenter @hanzei @m1lt0n @trilopin