-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt memorystore for tests #745
Conversation
@mickmister @raghavaggarwal2308 Gentle reminder to review the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hanzei LGTM 👍🏽
Note: tests are failing in CI
I've reached out to @ayusht2810 regarding the failing CI in https://community.mattermost.com/core/pl/z7833z1f6iyaibmib4af13fzar |
@hanzei The tests are working fine on my local for master and your branch as well. Can you please try re-running the CI here? |
@raghavaggarwal2308 I've re-triggered CI, which fixed the issue. Please note that the tests on |
Ok, |
@raghavaggarwal2308 @mickmister Do you think adopting the memory store would be helpful for other plugins that extensively make use of the KV store like Gitlab or JIRA? |
@raghavaggarwal2308 The nightly run failed again: https://github.com/mattermost/mattermost-plugin-github/actions/runs/8164766247/job/22320677668 |
@hanzei I tried running the commands locally many times but was not really able to reproduce this. |
My own tests were the ones that were flaky. 🤦 Submitted mattermost/mattermost-plugin-starter-template#197. |
Summary
This PR adopts the MemoryStore (mattermost/mattermost#26244) from the tests in
server/plugin/subscriptions_test.go
and removes the mocks.I've included a cleanup of
p.API
usage via 3f0f4fc in this PR.Ticket Link
None