Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestFilterLogEntries #753

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fix flaky TestFilterLogEntries #753

merged 1 commit into from
Mar 21, 2024

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Mar 20, 2024

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Mar 20, 2024
@hanzei hanzei requested a review from mickmister as a code owner March 20, 2024 11:47
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.16%. Comparing base (0100b54) to head (8fcd74c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #753   +/-   ##
=======================================
  Coverage   16.16%   16.16%           
=======================================
  Files          17       17           
  Lines        6021     6021           
=======================================
  Hits          973      973           
  Misses       5003     5003           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mickmister
Copy link
Member

@ayusht2810 @raghavaggarwal2308 FYI this may need to be applied to other plugin repos as well. @hanzei What's the drawback to not updating this on a plugin repo? Do the unit tests fail?

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 21, 2024
@hanzei
Copy link
Contributor Author

hanzei commented Mar 21, 2024

Do the unit tests fail?

The tests are flaky and fail from time to time.

@hanzei hanzei merged commit b46157b into master Mar 21, 2024
9 checks passed
@hanzei hanzei deleted the flaky-log-filter-test branch March 21, 2024 08:11
@hanzei hanzei added this to the v2.3.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants