Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest development main of wheel is missing pkginfo #135

Closed
henryiii opened this issue Dec 30, 2021 · 1 comment · Fixed by #136
Closed

Latest development main of wheel is missing pkginfo #135

henryiii opened this issue Dec 30, 2021 · 1 comment · Fixed by #136
Labels
bug

Comments

@henryiii
Copy link

Describe the bug
wheel.pkginfo was removed.

To Reproduce
Use an unreleased version of wheel.

Expected behavior
Not break.

Wheels used
The import is missing, so no need for a wheel.

Platform (please complete the following information):

  • OS version: any
  • Delocate version: any

Additional context

See: pypa/wheel#433
@henryiii henryiii added the bug label Dec 30, 2021
@HexDecimal HexDecimal mentioned this issue Dec 31, 2021
Merged
@HexDecimal
Copy link
Collaborator

Thanks for bringing this up before the next release of wheel.

matthew-brett added a commit that referenced this issue Dec 31, 2021
@matthew-brett
Merge pull request #136 from HexDecimal/fix-135
54a30f8 
MRG: Replicate the to-be-removed `wheel.pkginfo` module.

The plans to remove the `wheel.pkginfo` module can be negotiated with the `wheel` devs, but this PR should cause less drama.

Adds `delocate.pkginfo` to read/write these files, based on the original module.

Removes code supporting `wheel<0.32.0`.  Adds code to support the unreleased versions of `wheel>0.37.1`.

Adds type hinting to the relevant functions.

Closes #135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replicate the to-be-removed wheel.pkginfo module. HexDecimal/delocate
2 participants
@HexDecimal @henryiii