Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate the to-be-removed wheel.pkginfo module. #136

Merged
merged 1 commit into from
Dec 31, 2021

Conversation

HexDecimal
Copy link
Collaborator

The plans to remove the wheel.pkginfo module can be negotiated with the wheel devs, but this PR should cause less drama.

Adds delocate.pkginfo to read/write these files, based on the original module.

Removes code supporting wheel<0.32.0. Adds code to support the unreleased versions of wheel>0.37.1.

Adds type hinting to the relevant functions.

Closes #135

Adds delocate.pkginfo to read/write these files, based on the original module.

Removes code handling for older versions of wheel.
@matthew-brett
Copy link
Owner

Worth also copying the test_pkginfo.py test?

@HexDecimal
Copy link
Collaborator Author

Worth also copying the test_pkginfo.py test?

I thought of that, but looking at the test and the code, the test is just making sure that email.generator works rather than anything more specific to the function itself.

All 3 functions are covered by other tested functions which rely on them.

@matthew-brett
Copy link
Owner

OK - nice - thanks for doing that so fast.

@matthew-brett matthew-brett merged commit 54a30f8 into matthew-brett:master Dec 31, 2021
@HexDecimal HexDecimal deleted the fix-135 branch December 31, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest development main of wheel is missing pkginfo
2 participants