Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitize rpaths by default #223

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Aug 27, 2024

Pull Request Checklist

  • Read and follow the CONTRIBUTING.md guide
  • Mentioned relevant issues
  • Append public facing changes to Changelog.md
  • Ensure new features are covered by tests
  • Ensure fixes are verified by tests

adopts #101 as default behavior with new --no-sanitize-rpaths opt-out. --sanitize-rpaths kept for backward compatibility.

@minrk minrk mentioned this pull request Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (de38e09) to head (37f0bbb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #223   +/-   ##
=======================================
  Coverage   96.93%   96.94%           
=======================================
  Files          16       16           
  Lines        1307     1308    +1     
=======================================
+ Hits         1267     1268    +1     
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@HexDecimal HexDecimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a test to verify that --no-sanitize-rpaths works as intended.

delocate/cmd/common.py Outdated Show resolved Hide resolved
@HexDecimal HexDecimal linked an issue Aug 27, 2024 that may be closed by this pull request
@HexDecimal HexDecimal merged commit a21c657 into matthew-brett:master Aug 29, 2024
16 checks passed
@minrk minrk deleted the sanitize-default branch August 29, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sanitize rpaths
2 participants