Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanitize rpaths by default #223

Merged
merged 3 commits into from
Aug 29, 2024
Merged

sanitize rpaths by default #223

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8abf9fb
sanitize rpaths by default
minrk Aug 22, 2024
d32ecbf
changelog for sanitize-rpaths
minrk Aug 27, 2024
37f0bbb
test sanitize_rpaths toggles
minrk Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ rules on making a good Changelog.

### Changed

- Sanitize rpaths (`--sanitize-rpaths`) is now the default behavior.
Opt out with new `--no-sanitize-rpaths` [#223](https://github.com/matthew-brett/delocate/pull/223)
- Improved error message for when a MacOS target version is not met.
[#211](https://github.com/matthew-brett/delocate/issues/211)
- `delocate-fuse` is no longer available and will throw an error when invoked.
Expand Down
9 changes: 8 additions & 1 deletion delocate/cmd/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,15 @@
delocate_parser.add_argument(
"--sanitize-rpaths",
action="store_true",
help="Remove absolute and relative rpaths from binaries",
help="Remove absolute and relative rpaths from binaries (default)",
)
delocate_parser.add_argument(
"--no-sanitize-rpaths",
action="store_false",
dest="sanitize_rpaths",
help="Don't remove absolute and relative rpaths from binaries",
)
delocate_parser.set_defaults(sanitize_rpaths=True)
minrk marked this conversation as resolved.
Show resolved Hide resolved


def verbosity_config(args: Namespace) -> None:
Expand Down