Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node-qunit-puppeteer for CI tests #229

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Use node-qunit-puppeteer for CI tests #229

merged 2 commits into from
Dec 14, 2024

Conversation

matthewp
Copy link
Owner

I had previously forked the project as it was falling behind, but it's since been more actively maintained so it should be safe to use, and will give us a newer version of Chromium.

Should fix #227

@matthewp
Use node-qunit-puppeteer for CI tests
6d6f0c9 
I had previously forked the project as it was falling behind, but it's
since been more actively maintained so it should be safe to use, and
will give us a newer version of Chromium.

Should fix #227
@matthewp
Copy link
Owner Author

Putting back into draft, more complicated it seems.

@matthewp matthewp marked this pull request as draft December 14, 2024 13:40
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2024

⚠️ No Changeset found

Latest commit: 1c82147

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

matthewp
matthewp commented Dec 14, 2024
View reviewed changes
.github/workflows/nodejs.yml
@@ -5,7 +5,7 @@ on: [push]
jobs:
build:

runs-on: ubuntu-latest
runs-on: ubuntu-22.04
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because of a Chromium bug, see puppeteer/puppeteer#12818

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll subscribe to that bug. Ideally we can re-instate ubuntu-latest at some point.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, that bug is closed. I'll go hunt for a bug about the override for runs-on.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that was closed because its really a Chromium bug which is here: https://issues.chromium.org/issues/373753919

@matthewp matthewp marked this pull request as ready for review December 14, 2024 13:45
@matthewp matthewp requested a review from ehuelsmann December 14, 2024 13:45
@matthewp matthewp merged commit c9014ef into main Dec 14, 2024
2 checks passed
@matthewp matthewp deleted the fix-tests-2 branch December 14, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuelsmann ehuelsmann ehuelsmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test failures on GitHub Actions (Browser environment crashing)
2 participants
@matthewp @ehuelsmann