Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node-qunit-puppeteer for CI tests #229

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Use node-qunit-puppeteer for CI tests #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d6f0c9
Use node-qunit-puppeteer for CI tests
matthewp Dec 14, 2024
1c82147
Use Ubuntu 22.04
matthewp Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on: [push]
jobs:
build:

runs-on: ubuntu-latest
runs-on: ubuntu-22.04
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because of a Chromium bug, see puppeteer/puppeteer#12818

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll subscribe to that bug. Ideally we can re-instate ubuntu-latest at some point.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, that bug is closed. I'll go hunt for a bug about the override for runs-on.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that was closed because its really a Chromium bug which is here: https://issues.chromium.org/issues/373753919


strategy:
matrix:
Expand Down
Loading