ember-cli-coffee-snippets #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing syntax bug
| '.source.coffee': | ||
|
|
||
| 'Ember fixtureAdapter': | ||
| 'prefix': 'ds.fixA' |
There was a problem hiding this comment.
Can you use more clear prefix like fixture-adapter, so it's similar to the rest of the rest of the project. Also please apply this concept to the rest of the prefixes. (rest-adapter, active-adapter)
Can you also move adapters to modules.cson
imports separated as well as changing the prefixes.
Merged
|
Hey @imanghafoori1. These PR's have been sitting for a while and I'm going close them. I've decided to deprecate coffeescript support as it's not the community standard at this point. I'll keep around the existing snippets but will not be updating them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These snippets are optimized for and written with ember-cli and coffeeScript in mind.