Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coffeescript bindings #5

Merged
merged 2 commits into from
Apr 11, 2015
Merged

Conversation

jgarth
Copy link
Contributor

@jgarth jgarth commented Apr 5, 2015

Hi @seifsallam,

Thanks for publishing your snippets. I took the liberty of duplicating all snippets in CoffeeScript. I've also adjusted the Readme, Changelog and package.json. Would you be willing to pull them into your package? Let me know if any additional changes are necessary.

@jgarth
Copy link
Contributor Author

jgarth commented Apr 5, 2015

Whoa, I could swear I saw no pull requests for this and now I can see there are three already... my bad! Feel free to close & ignore in favor of #2 / #3 / #4

@seifsallam
Copy link
Collaborator

@jgarth This looks more ready. Can you just update the .property and .observer to use new syntax Ember.computed and Ember.observer emberjs/guides#110

@jgarth
Copy link
Contributor Author

jgarth commented Apr 11, 2015

Thanks for the hint, the new syntax seems much nicer in conjunction with CoffeeScript.

seifsallam added a commit that referenced this pull request Apr 11, 2015
@seifsallam seifsallam merged commit 7f963da into mattmcmanus:master Apr 11, 2015
@seifsallam
Copy link
Collaborator

@jgarth I've updated the package. Thanks for your PR 👍

@jgarth jgarth deleted the coffeescript branch April 11, 2015 15:42
@jgarth
Copy link
Contributor Author

jgarth commented Apr 11, 2015

Cheers! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants