Pro fancy version for coffeeScript syntax #3
Conversation
es6 syntax snippets
logger--help<tab>
| 'prefix': 'arrayController' | ||
| 'body': | ||
| """ | ||
| _export = Ember.ArrayController.extend( |
There was a problem hiding this comment.
This is way complicated. Can we simplify this, to make it just the bare minimum. It should only contain body
There was a problem hiding this comment.
Yes, I just had forgotten to delete them.
thank you.
|
You've done some awesome work, and i like the new file structure (except for other, and wrappers). About having shorthand + long form When we type, we type words not characters (same way we read). We don’t think about single characters in isolation. We don’t type I understand your point of view. And I’ve used it before, but it didn’t turnout well, especially when collaboration with other. Everyone had their way of naming things, and their own conventions, despite having a clear guidelines. Even you couple of month not using ember, and going back you'll have all those shorthands forgotten. (Saying this from an experience) Plus, most of the words are not that big, with the exception of a few. I simply don’t see the point in changing the way we type Another main issue is that if atom fixes or supports autocomplete for snippets tomorrow, having shorthand should be deprecated, or it will generate 2 autocomplete suggestions for each snippet. So again, I appreciate the amount of effort that you've put into this, but it will be harder for you to maintain such thing. |
|
ok, I agree with you. *--help snippets (such as model--help) Are meant to be used in case you or forget or suspect what to type! I tried to design the package in a way that if the user is not happy with the shorthands he or she can ignore them all together. no big deal. ;) with the help of this nice handy package, it seems redundant to have the shorthands. I remove the wrappers and shorthands on the next commit. |
the body is place on only one line.
get("model") -> get("key")
sen -> send was removed.
|
After all thank you for comments. sayyedi ;) shokran |
|
Awesome. About the snippets, we can add it to the |
|
|
||
| 'Ember computed alias map': | ||
| 'prefix': 'computed.map' | ||
| 'body': " Ember.computed.map('${1:array_property}', (item, index) -> |
There was a problem hiding this comment.
Can you change quotations with multiline quotations
|
Can you run the files against a coffee script linter, to clean things up, like removing extra lines, and spaces before comas, and other small stuff like that for consistency. Other than that, and the inline comments, your work looks pretty good! 👍 |
|
I am working on a much better branch specially optimized to work with "autocomplete-snippets" package. |
Happy to see your comments...