-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimized for autocomplete+ snippets #4
Optimized for autocomplete+ snippets #4
Conversation
'import custom from...': 'prefix': 'emEs6.custom' 'body': """ `import ${1:var} from './${2}';` """
since the autocomeletion had trouble with dot , I was forced to change it to underscores. - emView.willClearRender -> emView_willClearRender
Awesome work, but there are still some comments regarding the changes. I think prefixes needs more work. Some has short hand, some has underscore, some has dashes, some has both, and some had dots For starters, lets use full names for everything. So using For separating the words, I don't think it's a good idea to use underscores, it's not really a JavaScript convention, so i'm leaning more toward matching syntax with the function itself. That means using CamelCase to call For case that require use of dot, lets use dot. like For using DS, and Ember. I don't agree that we have to namespace it. Unless there is a conflict locally, we should use direct function names. For Angular and other users, I think that would be a rare case to stumble upon. And in that instance, they can disable this snippet. For es6, it should be So as a rule, lets just match the prefix with the real syntax, that matches people's expectations. And lets ditch DS or Ember. Finally, there should be maximum of one line spacing between text lines in all files. |
On the last commits I changed all of them to _ underscores. em_view_... |
Awesome, but still. As I said above. It's better to match the prefix to the real sytanx of what people would write. Also there are cases that you've missed like |
I provided 2 prefixes to import and export. (bot with and without the es6_) Let them live there, I think they are not problematic or cause any conflict. es6_
They are ready, I think. Just forgive me about the extra linebreakes. |
|
||
|
||
'Ember willClearRender Hook': | ||
'prefix': 'view_willClearR' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix this. view_willClearRender
I provided to set of prefixes. just bare with me they are useful specially for new comers to the package.
'.source.coffee': | ||
|
||
'Ember FixtureAdapter': | ||
'prefix': 'adapter_fixture' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixture_adapter
I tried to group all adapters under the adapter keyword, |
activemodel_adapter rest_adapter fixture_adapter prefixes added.
Again, Happy to have you as a teammate. |
New file added
https://github.com/atom-community/autocomplete-snippets
try the snippets below:
emView
emArrayController
dsModel
emComputed
,...