Jenkins: bring Jenkinsfile back #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dagar any idea what this means? |
|
Long story, but newer Jenkins doesn't like the way we were hanlding entrypoint.sh. https://github.com/Dronecode/DronecodeSDK/blob/develop/docker/Dockerfile-Ubuntu-16.04#L54 See (aka copy) what was done in PX4/containers for detail. https://github.com/PX4/containers/blob/master/docker/px4-dev/scripts/entrypoint.sh @lamping7 FYI |
|
Oh, right, so I need to change all of the docker stuff, ok. |
julianoes
force-pushed
the
add-jenkins-again
branch
from
e88b12b to
405fdd8
Compare
This reverts commit d60c07f.
This is an attempt to get the docker images compatible with Jenkins. We now add a user with ID 1001, so matching the default Jenkins user which is used if no $LOCAL_USER_ID is supplied. Also, we use su-exec instead of su hoping because it seems to print less errors.
This should not be needed anymore because the default is to use the Jenkins default user.
Instead just switch to it.
julianoes
force-pushed
the
add-jenkins-again
branch
from
827206b to
98b1ac3
Compare
julianoes
force-pushed
the
add-jenkins-again
branch
from
2076e36 to
3368882
Compare
|
@dagar this seems to work now but I'd appreciate a review regarding ccache. I don't think it's working. |
JonasVautherin
approved these changes
Mar 26, 2019
|
According to @dagar we are lucky if ccache works because the ec2 instance has not been recycled yet. Otherwise that's what we have for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's get Jenkins up and running again, FYI @dagar 😄