integration_tests: add checks to takeoff/land test #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integration_tests/simple_hover.cpp
Outdated
|
|
||
| Device &device = dc.device(); | ||
|
|
||
| while (!device.telemetry().health_all_ok()) { | ||
| for (int i = 0; ; ++i) { |
There was a problem hiding this comment.
Just FMI, why not a while loop? Seem odd to see an infinite for loop :-)
There was a problem hiding this comment.
Ignore that, I see you want to count out 10 seconds.
There was a problem hiding this comment.
Yer it's a bit ugly but I haven't found a prettier way yet.
An alternative is to use the async interface and then do a wait_for on the promise.
There was a problem hiding this comment.
Not prettier, but perhaps a little more intuitive
int itter=0;
while (!device.telemetry().health_all_ok()) {
std::cout << "waiting for device to be ready" << std::endl;
std::this_thread::sleep_for(std::chrono::seconds(1));
ASSERT_LT(++itter, 10);
}
There was a problem hiding this comment.
Yer, you're right. That's nicer. I'll change it.
Old debug info text had typo ("success, not "sucess") but in any case was not useful because there was no information about the context of the success.
This adds a sync interface for the connection status of a device. It is basically the same information as also covered by the async methods on_discover and on_timeout.
This adds some checks to the ActionSimpleHover tests to actually check what PX4 SITL is executing rather than just checking if we get the correct responses. This could be an example for CI tests for PX4 using DroneCore.
julianoes
force-pushed
the
sitl-test
branch
from
c30b12a
to
594411d
Compare
|
Replaced by #110. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some checks to the ActionSimpleHover tests to actually check
what PX4 SITL is executing rather than just checking if we get the
correct responses.
This could be an example for CI tests for PX4 using DroneCore.
@dagar have a look
To test this:
Or if you have Firmware and DroneCore next to each other in a folder: