-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
e7aa338
to
b25c480
Compare
@@ -838,63 +763,181 @@ async function initMazedPartsOfTab( | |||
} | |||
} | |||
|
|||
browser.tabs.onRemoved.addListener( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shows up as a big change, but I just moved most of the background init into an initBackground()
function. I did it because before I can call makeStorageApi
I need to fetch the AppSettings
which is an async call. I couldn't do an async call while keeping the init code structurally the same at the top level of the file since we can't use async there
Toggle was moved to a dedicated page |
Looks marvellous! Do you mind covering toggle with Posthog feature flag (showing it only for 3 of us)? It's super easy to add : https://eu.posthog.com/feature_flags/new |
(testing the rest locally, will get back in ~10 min) |
In Chrome. Settings page doesn't work for me, in error log it prints:
|
Swap this with the ID that got generated for your local version of archaeologist |
It works with changed ID 🚀 thansk! |
Something is broken in Triptych, right hand side cards are not rendered (even manual ones), see demo: Screen.Recording.2023-01-20.at.09.44.26.movUpdate 1: Update 2: |
Unexpectedly change behaviour - sorting of notes in search results is reversed. Latest notes have to be on top of the grid and scrolling down you go back in time ⏳ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This PR adds a very bare-bones way to switch between the type of storage Mazed uses. I want to get something out the door that will allow us to start testing local hosting internally, so I'm looking for the minimal amount of work to make it happen. Looking for feedback what's "good enough" and acceptable!
With that in mind
I think the location of the button is probably bad (but it was quickest to add it there)location was moved to a dedicated settings pageStorageApi
type for content and popup has been changed to unconditionally use a message proxy implementation, so even when the "datacenter" hosting is active, content and popup will no longer send requests to smuggler, they will send a request to background which will pass it to smugglerTODO:
Media1.mp4