Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

propagate errors from archaeologist to truthsayer #435

Merged
merged 2 commits into from
Feb 12, 2023

Conversation

SergNikitin
Copy link
Collaborator

Currently if archaeologist throws when it processes a message from truthsayer then truthsayer will get back an object which looks like

{ __mozWebExtensionPolyfillReject__: true, message: 'error description' }

This gets mistakenly interpreted as ToTruthsayer.Response which leads to obscure red herring errors like

Screenshot 2023-01-20 at 09 52 19

instead of

Screenshot 2023-01-20 at 09 52 19

Obscure errors lead to slower root cause analysis.

@SergNikitin SergNikitin added bug Something isn't working impact [XXS] effort [XXXS] Less than 1 hour truthsayer labels Feb 11, 2023
@SergNikitin SergNikitin mentioned this pull request Feb 11, 2023
8 tasks
Copy link
Contributor

@akindyakov akindyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!

@akindyakov akindyakov merged commit e01a0fb into main Feb 12, 2023
@akindyakov akindyakov deleted the better-propagate-errs-from-ext-to-webapp branch February 12, 2023 13:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working effort [XXXS] Less than 1 hour impact [XXS] truthsayer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants