refactor:test(ex/skate_web/detour_controller): use :user factory (#…

…2896)
mbta · Nov 14, 2024 · bf5f673 · bf5f673
1 parent d41b967
commit bf5f673
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/test/skate_web/controllers/detours_controller_test.exs b/test/skate_web/controllers/detours_controller_test.exs
@@ -275,9 +275,7 @@ defmodule SkateWeb.DetoursControllerTest do
     test "will not return detours from other users", %{conn: conn} do
       current_user_id = populate_db_and_get_user(conn)
 
-      Skate.Settings.User.upsert("other_user", "other_user@gmail.com")
-
-      other_user = Skate.Settings.User.get_by_email("other_user@gmail.com")
+      other_user = build(:user)
 
       # Manually insert a detour by another user
       Detours.upsert_from_snapshot(other_user.id, %{