Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor:test(ex/skate_web/detour_controller): use :user factory #2896

Merged
merged 3 commits into from
Nov 14, 2024
Merged

refactor:test(ex/skate_web/detour_controller): use :user factory #2896

merged 3 commits into from
Nov 14, 2024

Conversation

firestack
Copy link
Member

@firestack firestack commented Nov 4, 2024 •
edited
Loading

@firestack firestack force-pushed the kf/asn/deserializer branch from 5a6de67 to f0b86b8 Compare November 4, 2024 18:43
@firestack firestack force-pushed the kf/cleanup/use-user-factory branch from 71b9cf2 to bd505f0 Compare November 4, 2024 18:43
@firestack firestack marked this pull request as ready for review November 4, 2024 18:49
@firestack firestack requested a review from a team as a code owner November 4, 2024 18:49
Base automatically changed from kf/asn/deserializer to main November 7, 2024 15:25
@firestack firestack enabled auto-merge (squash) November 7, 2024 15:55
@firestack firestack disabled auto-merge November 7, 2024 15:55
@firestack firestack enabled auto-merge (squash) November 7, 2024 15:55
hannahpurcell
hannahpurcell approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is larger than I think it's supposed to be -- seems like the only change is line 14 of the test? Nothing looks out of place from main, though! so ✅

@firestack firestack merged commit bf5f673 into main Nov 14, 2024
33 checks passed
@firestack firestack deleted the kf/cleanup/use-user-factory branch November 14, 2024 02:14
@hannahpurcell
Copy link
Collaborator

Whoops, I didn't think about auto-merge, but hopefully all is well!

@firestack
Copy link
Member Author

The diff is larger than I think it's supposed to be -- seems like the only change is line 14 of the test? Nothing looks out of place from main, though! so ✅

Correct, looks like I didn't rebase this so it reported wrong.

Whoops, I didn't think about auto-merge, but hopefully all is well!

Looks like it turned out okay though! bf5f673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahpurcell hannahpurcell hannahpurcell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firestack @hannahpurcell