feat: make categorize_detour/2 public
#2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
force-pushed
the
kf/feat/pub-category
branch
from
cbcbec8 to
80b04a0
Compare
Coverage of commit
|
joshlarson
reviewed
Sep 26, 2024
| @@ -95,19 +95,25 @@ defmodule Skate.Detours.Detours do | |||
|
|
|||
| @type detour_type :: :active | :draft | :past | |||
|
|
|||
| @doc """ | |||
There was a problem hiding this comment.
Non-blocking, but wouldn't hate this as a fast-follow: This is a good candidate for doctests.
There was a problem hiding this comment.
agreed! I don't think I have the bandwidth for that right now, but I'd take a commit if you wanted to.
There was a problem hiding this comment.
Let's not block this PR on that - I'll queue it up as a fast-follow and see if I can get it done in the 16 hours remaining to me.
joshlarson
reviewed
Sep 26, 2024
firestack
force-pushed
the
kf/feat/pub-category
branch
from
80b04a0 to
427f1a3
Compare
Coverage of commit
|
joshlarson
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
I disabled auto-merge so that you can respond to #2820 (comment), but I think this looks good once that's addressed.
firestack
force-pushed
the
kf/feat/pub-category
branch
from
427f1a3 to
3676f43
Compare
firestack
force-pushed
the
kf/feat/pub-category
branch
from
3676f43 to
a226e00
Compare
Coverage of commit
|
Coverage of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.