Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send detour notification when detour is activated #2821

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

@firestack firestack force-pushed the kf/asn/dn/controller-notifications branch 4 times, most recently from 8b50f4b to c14ed1e Compare September 26, 2024 13:39
@firestack firestack force-pushed the kf/asn/dn/notification-server branch from 313828a to 64d4d59 Compare September 26, 2024 13:39
@firestack firestack force-pushed the kf/asn/dn/controller-notifications branch from c14ed1e to c5dfd09 Compare September 26, 2024 14:38
@firestack firestack force-pushed the kf/asn/dn/notification-server branch from 64d4d59 to 1454143 Compare September 26, 2024 14:39
@firestack firestack force-pushed the kf/asn/dn/controller-notifications branch from c5dfd09 to 26c998a Compare September 26, 2024 14:39
@firestack firestack force-pushed the kf/asn/dn/notification-server branch from 1454143 to a8fb678 Compare September 26, 2024 15:02
@firestack firestack force-pushed the kf/asn/dn/controller-notifications branch from 26c998a to 472af53 Compare September 26, 2024 15:02
@firestack firestack force-pushed the kf/asn/dn/notification-server branch from a8fb678 to dfde647 Compare September 26, 2024 15:23
@firestack firestack force-pushed the kf/asn/dn/controller-notifications branch from 472af53 to 1b39979 Compare September 26, 2024 15:23
@firestack firestack marked this pull request as ready for review September 26, 2024 15:41
@firestack firestack requested a review from a team as a code owner September 26, 2024 15:41
@firestack firestack force-pushed the kf/asn/dn/controller-notifications branch from 1b39979 to a21515b Compare September 26, 2024 15:58
@firestack firestack force-pushed the kf/asn/dn/notification-server branch from dfde647 to 12fa629 Compare September 26, 2024 15:58
@firestack firestack force-pushed the kf/asn/dn/controller-notifications branch from a21515b to eace6d1 Compare September 26, 2024 16:01
@firestack firestack force-pushed the kf/asn/dn/notification-server branch 2 times, most recently from 2c20a1f to ead40ab Compare September 26, 2024 16:11
@firestack firestack force-pushed the kf/asn/dn/controller-notifications branch 2 times, most recently from 0649891 to f5ddf82 Compare September 26, 2024 16:11
@firestack firestack force-pushed the kf/asn/dn/notification-server branch from 1c1200b to 25bf191 Compare September 26, 2024 16:29
@firestack firestack force-pushed the kf/asn/dn/controller-notifications branch from f5ddf82 to a6c1355 Compare September 26, 2024 16:29
@mbta mbta deleted a comment from github-actions bot Sep 26, 2024
@mbta mbta deleted a comment from github-actions bot Sep 26, 2024
@mbta mbta deleted a comment from github-actions bot Sep 26, 2024
@mbta mbta deleted a comment from github-actions bot Sep 26, 2024
@mbta mbta deleted a comment from github-actions bot Sep 26, 2024
@mbta mbta deleted a comment from github-actions bot Sep 26, 2024
@mbta mbta deleted a comment from github-actions bot Sep 26, 2024
@mbta mbta deleted a comment from github-actions bot Sep 26, 2024
@mbta mbta deleted a comment from github-actions bot Sep 26, 2024
@mbta mbta deleted a comment from github-actions bot Sep 26, 2024
@mbta mbta deleted a comment from github-actions bot Sep 26, 2024
@mbta mbta deleted a comment from github-actions bot Sep 26, 2024
@mbta mbta deleted a comment from github-actions bot Sep 26, 2024
@firestack firestack force-pushed the kf/asn/dn/controller-notifications branch from a6c1355 to b7f30b6 Compare September 27, 2024 12:11
@firestack firestack force-pushed the kf/asn/dn/notification-server branch from 25bf191 to 9939117 Compare September 27, 2024 12:11
@firestack firestack force-pushed the kf/asn/dn/controller-notifications branch from b7f30b6 to e55b5f9 Compare September 27, 2024 12:11
@firestack firestack force-pushed the kf/asn/dn/notification-server branch from 9939117 to 76a38d8 Compare September 27, 2024 12:11
@firestack firestack force-pushed the kf/asn/dn/controller-notifications branch from e55b5f9 to 45bbfbf Compare September 27, 2024 12:13
@firestack firestack force-pushed the kf/asn/dn/notification-server branch from 76a38d8 to f692394 Compare September 27, 2024 12:13
Base automatically changed from kf/asn/dn/notification-server to main September 27, 2024 12:38
@firestack firestack force-pushed the kf/asn/dn/controller-notifications branch from 45bbfbf to 9dd70f4 Compare September 27, 2024 12:51
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fab! Looks great to me. Optional naming suggestion only

lib/skate/detours/detours.ex Outdated Show resolved Hide resolved
@firestack firestack force-pushed the kf/asn/dn/controller-notifications branch from 9dd70f4 to 9eeaca1 Compare September 30, 2024 14:29
@firestack
Copy link
Member Author

This PR requires #2830, so this is blocked till it's merged.

@firestack firestack merged commit c15fb79 into main Sep 30, 2024
21 checks passed
@firestack firestack deleted the kf/asn/dn/controller-notifications branch September 30, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants