refactor(ex/skate/detours): pattern match in send_notification
#2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
force-pushed
the
kf/asn/deserializer
branch
from
5a6de67 to
f0b86b8
Compare
firestack
force-pushed
the
kf/refactory/send-notification-match
branch
from
b2c706e to
fe09697
Compare
firestack
force-pushed
the
kf/refactory/send-notification-match
branch
from
fe09697 to
5501593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely certain on this, because I'm not certain that the
send_notificationfunction should pattern match on a DB result like this.Depends on: