fix: FCM error handling #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpopp
added a commit
that referenced
this pull request
Jan 17, 2024
* fix: move token generation to agent (#1) * fix: add uri to token storage key to prevent clashes (#2) * Catch up with upstream (#3) * fix: allow httpoison 2.0 (codedge-llc#236) * fix: allow httpoison 2.0 * ci: fix workflows * ci: revert to ubuntu-latest * ci: use setup-beam@v1 * chore: update CHANGELOG * docs: update README links * fix: move token generation into Pigeon.APNS.Token (codedge-llc#227) This means the token is only generated once and used across all workers * chore: update CHANGELOG --------- Co-authored-by: Henry Popp <hpopp@users.noreply.github.com> Co-authored-by: Henry Popp <henry@codedge.io> Co-authored-by: Andrew Timberlake <andrew@andrewtimberlake.com> * chore: run mix format on our changes (#4) * fix: allow httpoison 2.0 (codedge-llc#236) * fix: allow httpoison 2.0 * ci: fix workflows * ci: revert to ubuntu-latest * ci: use setup-beam@v1 * chore: update CHANGELOG * docs: update README links * fix: move token generation into Pigeon.APNS.Token (codedge-llc#227) This means the token is only generated once and used across all workers * chore: update CHANGELOG --------- Co-authored-by: Henry Popp <hpopp@users.noreply.github.com> Co-authored-by: Henry Popp <henry@codedge.io> Co-authored-by: Andrew Timberlake <andrew@andrewtimberlake.com> * chore: undo random formatting changes that aren't necessary --------- Co-authored-by: Drew Ballance <drew@ballance.io> Co-authored-by: Henry Popp <hpopp@users.noreply.github.com> Co-authored-by: Henry Popp <henry@codedge.io> Co-authored-by: Andrew Timberlake <andrew@andrewtimberlake.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve FCM error handling by looking first at the errorCode, which is more informative than just the status.