chore: remove Internet Explorer detection #1566
Merged
+3
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
changed the title
caugner
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes bad browser support detection from the JavaScript editor. There is a clause that checks if
document.allis supported, assuming that IE10 and earlier are the only browsers that support it (and that it is non-standard). This assumption is false, however (see https://developer.mozilla.org/en-US/docs/Web/API/Document/all#Browser_compatibility); all modern browsers support it (and it is a part of the HTML standard). Additionally,document.allis interestingly falsy in browsers (!!document.all == false), so the code within theifblock was running anyways.Note: we can also just consider this code removal as dropping IE support!