Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Internet Explorer detection #1566

Merged
merged 2 commits into from
Nov 7, 2023
Merged

chore: remove Internet Explorer detection #1566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b97dfb5
Remove bad browser support detection
queengooborg Nov 4, 2023
f0d0661
Remove another instance
queengooborg Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions editor/js/editable-css.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,14 +138,8 @@ import "../css/editable-css.css";
}
}

/* only show the live code view if JS is enabled and the property is supported.
Also, only execute JS in our supported browsers. As `document.all`
is a non standard object available only in IE10 and older,
this will stop JS from executing in those versions. */
if (
cssEditorUtils.isAnyDeclarationSetSupported(exampleDeclarations) &&
!document.all
) {
/* only show the live code view if JS is enabled and the property is supported. */
if (cssEditorUtils.isAnyDeclarationSetSupported(exampleDeclarations)) {
enableLiveEditor();
mceEvents.onChoose(exampleChoices[initialChoice]);
clippy.toggleClippy(exampleChoices[initialChoice]);
Expand Down
5 changes: 1 addition & 4 deletions editor/js/editable-js.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,7 @@ import {
);
}

/* only execute JS in supported browsers. As `document.all`
is a non standard object available only in IE10 and older,
this will stop JS from executing in those versions. */
if (!document.all && featureDetector.isDefined(exampleFeature)) {
if (featureDetector.isDefined(exampleFeature)) {
document.documentElement.classList.add("js");

initInteractiveEditor();
Expand Down
Loading