-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with "Intl.NumberFormat() constructor": (narrowSymbol not supported on Safari) #9319
Comments
Do you have a test case that demonstrates the problem?
new Intl.NumberFormat('en-US', { style: 'currency', currency: 'USD', currencyDisplay: 'narrowSymbol' }).format(3500) The relevant Test262 test at https://test262.report/browse/intl402/NumberFormat/currencyDisplay-unit.js shows OK for JavaScriptCore for that test. |
I can drum up something end of day today. Not sure why test262 is reporting it that way. |
Preliminary assigned this issue to you, then, @cgarrovillo |
https://github.com/cgarrovillo/MDN-Intl.NumberFormat/tree/main I just realized I didnt format the |
OK, I’ve transferred this to the BCD repo, since that’s where we need to make a change. @cgarrovillo Thanks yeah, using he https://github.com/cgarrovillo/MDN-Intl.NumberFormat/tree/main document, I’ve also reproduced this and confirmed in my environment that Safari 14 reports an error. Interestingly, though, Safari Technology Preview (Release 119 (Safari 14.1, WebKit 16611.1.10.1)) doesn’t report an error. https://trac.webkit.org/changeset/266031/webkit shows that So we should document this in BCD by marking the Safari support with @cgarrovillo Do you want to take a shot at writing up patch/PR for that? (If not, I can do it.) I guess one of us should also raise an issue at https://github.com/tc39/test262/issues |
I could raise this issue over at test262. |
Code examination https://trac.webkit.org/changeset/266031/webkit indicates that support for compactDisplay, currencySign, notation, signDisplay, unit, unitDisplay, currencyDisplay: 'narrowSymbol', and style: 'unit'" wasn’t added until 2020-08-22 — and didn’t make it into Safari 14 (confirmed by testing), which was released 2020-09-16. Fixes mdn#9319
Code examination of https://trac.webkit.org/changeset/266031/webkit indicates that support for compactDisplay, currencySign, notation, signDisplay, unit, unitDisplay, currencyDisplay: 'narrowSymbol', and style: 'unit'" wasn’t added until 2020-08-22 — and didn’t make it into Safari 14 (confirmed by testing), which was released 2020-09-16. Fixes mdn#9319
Code examination of https://trac.webkit.org/changeset/266031/webkit indicates that support for compactDisplay, currencySign, notation, signDisplay, unit, unitDisplay, currencyDisplay: 'narrowSymbol', and style: 'unit' wasn’t added until 2020-08-22 — and didn’t make it into Safari 14 (confirmed by testing), which was released 2020-09-16. Fixes mdn#9319
OK, I’ve opened #9371 with an update for this. |
Code examination of https://trac.webkit.org/changeset/266031/webkit indicates that support for currencyDisplay: 'narrowSymbol' wasn’t added to WebKit until 2020-08-22 — and didn’t make it into Safari 14 (confirmed by testing), which was released 2020-09-16. Fixes mdn#9319
Code examination of https://trac.webkit.org/changeset/266031/webkit indicates that support for currencyDisplay: 'narrowSymbol' wasn’t added to WebKit until 2020-08-22 — and didn’t make it into Safari 14 (confirmed by testing), which was released 2020-09-16. Fixes mdn#9319
MDN URL: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat/NumberFormat
What information was incorrect, unhelpful, or incomplete?
The incompatibility table does not warn that narrowSymbol is not a valid option for Intl.NumberFormat
Specific section or headline?
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat/NumberFormat#browser_compatibility
What did you expect to see?
A warning for narrowSymbol incompatibility
Did you test this? If so, how?
Visited the website
MDN Content page report details
en-us/web/javascript/reference/global_objects/intl/numberformat/numberformat
The text was updated successfully, but these errors were encountered: