Mark Intl.NumberFormat support partial in Safari #9371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:js 📟
sideshowbarker
force-pushed
the
sideshowbarker/intl/NumberFormat-Safari-partial-support
branch
2 times, most recently
from
a213e1f
to
dc863bb
Compare
lucalves
approved these changes
Mar 8, 2021
|
hm, so this talks about features that are also sub features in the data. I think this makes the table quite inconsistent. Like, we don't usually mark the main feature as partial_support when there are additional features below that indicate the support for what you talk about in partial support. Do I make sense? |
sideshowbarker
force-pushed
the
sideshowbarker/intl/NumberFormat-Safari-partial-support
branch
from
dc863bb
to
d3d7456
Compare
Code examination of https://trac.webkit.org/changeset/266031/webkit indicates that support for currencyDisplay: 'narrowSymbol' wasn’t added to WebKit until 2020-08-22 — and didn’t make it into Safari 14 (confirmed by testing), which was released 2020-09-16. Fixes mdn#9319
sideshowbarker
force-pushed
the
sideshowbarker/intl/NumberFormat-Safari-partial-support
branch
from
d3d7456
to
1a39a51
Compare
Yup — make sense; I’ve amended the patch accordingly |
Elchi3
requested changes
Mar 19, 2021
Co-authored-by: Florian Scholz <fscholz@mozilla.com>
Elchi3
approved these changes
Mar 19, 2021
sideshowbarker
deleted the
sideshowbarker/intl/NumberFormat-Safari-partial-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code examination of https://trac.webkit.org/changeset/266031/webkit indicates that support for
currencyDisplay: 'narrowSymbol'wasn’t added to WebKit until 2020-08-22 — and didn’t make it into Safari 14 (confirmed by testing), released 2020-09-16.